Fix broken HTTP headers in elasticsearch requests #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
very good and really appreciated. i didn't knew it was so easy to support version 6, i thought more changes were going to be needed. anyways, i am testing it now and will merge if it works as stated. |
oxarbitrage
approved these changes
Feb 8, 2018
There was a problem hiding this comment.
works perfect. thanks.
i updated all the elasticsearch documentation in the wiki to version 6: https://github.com/bitshares/bitshares-core/wiki/ElasticSearch-Plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug results in Content-Type header not being set and this way preventing Elasticsearch from accepting the request. Every single request would fail with error 406.
Starting from version 6.0 Elasticsearch demands the Content-Type to be present and set. See the official post on the subject.
Tested with Elasticsearch 6.2.0